Skip to content

Remove very incomplete third party docutils/nodes.pyi #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2018
Merged

Remove very incomplete third party docutils/nodes.pyi #2439

merged 1 commit into from
Sep 13, 2018

Conversation

jdufresne
Copy link
Contributor

The stub contains only a single class. The doctuils.nodes module
contains many more classes than listed. The existence of this file
easily causes false positive failures of the form:

  error: Name 'nodes.Node' is not defined

Refs #1269

@srittau
Copy link
Collaborator

srittau commented Sep 11, 2018

While docutils is very incomplete indeed, I'd prefer to just have def __getattr__(name) -> Any: ... at the top-level of the modules to mark this, so we do not lose the (few) already annotated classes.

@jdufresne
Add def __getattr__(name) -> Any: ... to all docutils stubs
a3c07d6 
The stubs are very incomplete causing false positive when used. Add a
fallback to until they can become more complete.
@jdufresne jdufresne closed this Sep 13, 2018
@srittau
Copy link
Collaborator

srittau commented Sep 13, 2018

@jdufresne Did you mean to close this PR, since the changes look good me?

@srittau srittau mentioned this pull request Sep 13, 2018
Closed
@jdufresne jdufresne reopened this Sep 13, 2018
@jdufresne
Copy link
Contributor Author

@srittau Do you know why this change causes Travis failures on Python 3.6? It isn't clear to me.

srittau
srittau approved these changes Sep 13, 2018
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, the build failure seems unrelated to your changes, other PRs have the same problem, see issue #2456. I will merge when CI passes again.

@srittau srittau merged commit 47f22a3 into python:master Sep 13, 2018
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@jdufresne
Add def __getattr__(name) -> Any: ... to all docutils stubs (python…
b642d60 
…#2439)

The stubs are very incomplete causing false positive when used. Add a
fallback to until they can become more complete.
@jdufresne jdufresne deleted the rm-nodes branch December 15, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdufresne @srittau