Skip to content

Make isAlive available across all versions #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Make isAlive available across all versions #2565

merged 1 commit into from
Oct 27, 2018

Conversation

PrajwalM2212
Copy link
Contributor

@PrajwalM2212 PrajwalM2212 commented Oct 27, 2018

fixes #2552

isAlive is present in still present in threading.py in python 2.7, 3.4, 3.5, 3.6, 3.7. Hence I have removed the version guard.

@PrajwalM2212 PrajwalM2212 changed the title Remove version guard Make isAlive available across all versions Oct 27, 2018
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srittau srittau merged commit 9ee4582 into python:master Oct 27, 2018
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
isAlive() is still present in threading.py in python 2.7, 3.4, 3.5, 3.6, 3.7.

Closes python#2552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class Thread has an isAlive on Python 3.
2 participants