Stop inheriting Sized in collection ABCs #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead define abstract __len__ in affected classes. Fixes #2655 without breaking rominf/ordered-set-stubs#1
JukkaL
reviewed
Nov 30, 2018
JukkaL
reviewed
Nov 30, 2018
stdlib/3/typing.pyi
Outdated
| def __len__(self) -> int: ... | ||
|
|
||
| class Sequence(_Collection[_T_co], Reversible[_T_co], Generic[_T_co]): | ||
| class Sequence(Iterable[_T_co], Container[_T_co], Reversible[_T_co], Generic[_T_co]): |
There was a problem hiding this comment.
Maybe preserve _Collection here, as otherwise mypy could infer a less precise type for some type joins? Then you could leave out __len__ as it would be inherited.
JukkaL
reviewed
Nov 30, 2018
JukkaL
reviewed
Nov 30, 2018
|
You declare |
|
Some of the ABCs define various concrete methods that can act as default implementations. |
gvanrossum
added a commit
to python/mypy
that referenced
this pull request
Nov 30, 2018
To incorporate python/typeshed#2658
gvanrossum
added a commit
to python/mypy
that referenced
this pull request
Nov 30, 2018
To incorporate python/typeshed#2658
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Instead define abstract __len__ in affected classes. Fixes python#2655 without breaking rominf/ordered-set-stubs#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead define abstract len in affected classes.
Fixes #2655 without breaking
rominf/ordered-set-stubs#1