Skip to content

Adding stubs for pyre_extensions #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Adding stubs for pyre_extensions #3056

merged 1 commit into from
Jun 13, 2019

Conversation

mrkmndz
Copy link
Contributor

@mrkmndz mrkmndz commented Jun 13, 2019

Because it was decided (in python/typing#636) that CallableParametersVariable (now renamed ParameterSpecification) wasn't quite ready for inclusion in typing_extensions we went ahead and published our implementation under a new PyPI package, pyre_extensions (https://pypi.org/project/pyre-extensions/).
This is the corresponding typeshed stub.

@srittau
Copy link
Collaborator

srittau commented Jun 13, 2019

I am happy to include stubs for pyre_extensions in typeshed if you wish, but wouldn't it better to distribute them with pyre_extensions directly using PEP 561?

  • Less work for both the pyre and typeshed teams.
  • Stubs always match the implementation.

Normally typeshed includes stubs of packages where the maintainers don't want to or can't support type stubs themselves. Although I can't speak for the typing and mypy teams, I believe the inclusion of typing_extensions and mypy_extensions predate PEP 561.

@mrkmndz
Copy link
Contributor Author

mrkmndz commented Jun 13, 2019

Pyre does not yet support PEP 561 style stub lookup, and there are some specific deployment specific details internally which makes this approach preferable.

@srittau srittau merged commit 1f740a7 into python:master Jun 13, 2019
@grievejia grievejia mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants