zip: add some overloads for heterogeneous tuples #3830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically this is a lie, since we return a heterogeneous iterator, not a tuple. But since we don't have a way of typing heterogeneous iterators, this is the best we can do. Fixes python/mypy#8454
|
Could you fix the various CI failures? |
|
Suspected we'd see some issues. I think the best option here is to type ignore... |
|
Gentle bump! |
It looks like this needs to be reverted because lies break mypyc, see CI failure (unless @msullivan has an idea for workaround). |
|
Would changing the return type to Looks like we'd remain able to catch errors like: |
|
For now we are using |
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Jun 21, 2020
This reverts commit e857ad6.
JelleZijlstra
pushed a commit
that referenced
this pull request
Jun 25, 2020
|
Note, this was reverted in #4254 |
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
Technically this is a lie, since we return a heterogeneous iterator, not a tuple. But since we don't have a way of typing heterogeneous iterators, this is the best we can do. Fixes python/mypy#8454
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
…" (python#4254) This reverts commit e857ad6. Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically this is a lie, since we return a heterogeneous iterator, not
a tuple. But since we don't have a way of typing heterogeneous
iterators, this is the best we can do.
Fixes python/mypy#8454