Skip to content

add overload to difflib.get_close_matches #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2020
Merged

add overload to difflib.get_close_matches #3908

merged 4 commits into from
Apr 5, 2020

Conversation

JelleZijlstra
Copy link
Member

Fixes #3906. Fixes #2067.

@JelleZijlstra JelleZijlstra mentioned this pull request Apr 5, 2020
Closed
McSinyx
McSinyx suggested changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@McSinyx McSinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bytes is also affected, so it might be a good idea to overload for AnyStr.

@JelleZijlstra
Copy link
Member Author

I think bytes is also affected, so it might be a good idea to overload for AnyStr.

Makes sense, I switched to AnyStr.

I don't want to think about what it would do in Python 2 if you mix str and unicode.

@srittau srittau merged commit 23e380a into master Apr 5, 2020
@srittau srittau deleted the difflib-get-close-matches branch April 5, 2020 12:12
vishalkuo pushed a commit to vishalkuo/typeshed that referenced this pull request Jun 26, 2020
@JelleZijlstra
add overload to difflib.get_close_matches (python#3908)
179ffbc 
Fixes python#3906. Fixes python#2067.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McSinyx McSinyx McSinyx requested changes

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@JelleZijlstra @srittau @McSinyx