create _tkinter stub

[Akuli]

checks a checkbox in #1019

I thought I'd do some smaller tkinter PRs because #4363 doesn't seem to be getting merged in a while (needs conversation)

[Akuli]

How do I tell stubtest that an attribute comes from a __getattr__? By overloading __getattr__ with Literals?

[hauntsaninja]

stubtest is okay with attributes generally, because those are often defined on instances, so it can't get at them without instantiating. It does assume methods are not dynamically created though.
You have two options:
a) you can annotate your dynamic methods as attributes, eg: eval: Callable[[str], Any] (or for more complicated things, of type callback protocol). Depending on what getattr is doing, this might actually be more honest.
b) just add it to the stubtest whitelists (which I think is fine doing in this case). for an example in a similar vein, we whitelisted all of ast.NodeVisitor's visit_* methods.

Really appreciate all your improvements!

[Akuli]

ready for review

[Akuli]

How about putting the methods to a class named _Something and inheriting the two classes from that? This way there would be no copy/pasta.

[srittau]

Sorry for the delay and thank you for the much needed improvements to Tcl/Tk! Looks mostly good to me, with one nit below.

But on a general note: Stubs should only contain brief stub-related comments. Further documentation is out of scope for stubs and should be part of the documentation and/or implementation. If you want to document how you determined a certain type or possible problems for the reviewer to look out for, the best way to do that is with inline comments in the PR.

[srittau]

Nit (also applies to assignments below): = ... is redundant and should be left out.

[Akuli]

I made the comments more concise.

I can see how to apply these commenting guidelines to some of my comments in #4363, for example, and I will change that PR appropriately next. But sometimes I really want people working on the stubs to see something, even if they're adding something new rather than modifying something that I wrote. Can I still use comments for that?

Edit: nevermind, I think I understood this now