-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Re-organize directory structure #4971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OK, here is the situation: all tests pass, but I temporarily disabled two tests:
Somehow This is now ready for review, I am aiming to land this tomorrow morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM, with one question.
tests/mypy_test.py
Outdated
if name == PY2_NAMESPACE: | ||
continue | ||
mod, _ = os.path.splitext(name) | ||
if mod not in supported_versions or supported_versions[mod] > (major, minor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we print a warning or even fail the test if mod
is not in supported_versions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should, I was thinking about allowing some unrelated files in that directory (like some scripts etc). But we actually should keep directory structure clean. I will update this and will also add in a separate PR later a test that ensures stdlib
and stubs
have strict directory structure.
I believe I have pytype_test working again; it requires first a change to pytype itself (google/pytype#821), then an update to the test (26862d4). (It'll take at least a day for the pytype change to be reviewed and merged, so it still makes sense to disable pytype_test first and re-enable it later.) |
@rchen152 Great, thanks! I will then merge this now with pytype test disabled, and you can re-enable it whenever ready. |
Each stub now shows up with "1 contributor" on github, but if I look at the blame (by pressing |
This is a GitHub bug I think |
Follow up fo #4971 Co-authored-by: Ivan Levkivskyi <[email protected]>
See discussion in #2491
This PR needs a mypy commit that supports new directory structure (including
--custom-typeshed-dir
for standard library) landed in mypy master, which may take another day or two.cc @JukkaL