delete _importlib_modulespec #5350
Conversation
| # but expected in new code. | ||
| def exec_module(self, module: types.ModuleType) -> None: ... | ||
|
|
||
| class _LoaderProtocol(Protocol): |
There was a problem hiding this comment.
Nit: According to CONTRIBUTING, this should probably be called _SupportsLoadModule, although in this case, _LoaderProtocol also is a good name.
There was a problem hiding this comment.
And thinking a bit more about it: Maybe we should add a ...Protocol convention for protocols that mimic classes or abcs.
|
@rchen152 I think the CI failure is a bug in pytype: https://github.com/python/typeshed/runs/2517175044 |
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
4 similar comments
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
|
Diff from mypy_primer, showing the effect of this PR on open source code: alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
|
According to the comments,
_importlib_modulespecexists "for circular import reasons". But in general, circular imports should be fine in.pyifiles.