Skip to content

add missing arguments to croniter #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion stubs/croniter/@tests/stubtest_allowlist.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
croniter.CroniterError
croniter.croniter.__init__
croniter.croniter.__next__
croniter.croniter.expand
croniter.croniter.get_next
Expand Down
2 changes: 1 addition & 1 deletion stubs/croniter/METADATA.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = "0.1"
version = "1.0"
python2 = true
9 changes: 8 additions & 1 deletion stubs/croniter/croniter.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,14 @@ class croniter(Iterator[Any]):
dst_start_time: float
nth_weekday_of_month: Dict[str, Any]
def __init__(
self, expr_format: Text, start_time: float | datetime.datetime | None = ..., ret_type: _RetType | None = ...
self,
expr_format: Text,
start_time: float | datetime.datetime | None = ...,
ret_type: _RetType | None = ...,
day_or: bool = ...,
max_years_between_matches: int | None = ...,
is_prev: bool = ...,
hash_id: str | bytes | None = ..., # unicode not accepted on python 2
) -> None: ...
# Most return value depend on ret_type, which can be passed in both as a method argument and as
# a constructor argument.
Expand Down