Skip to content

Response.encoding can be None #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2021
Merged

Response.encoding can be None #6067

merged 1 commit into from
Sep 25, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Sep 24, 2021

No description provided.

Akuli
Akuli approved these changes Sep 25, 2021
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is intentional, since the implementation (requests.utils.get_encoding_from_headers) doesn't have an explicit return None and specifies :rtype: str in the docstring.

@Akuli Akuli merged commit 3128c6a into python:master Sep 25, 2021
@srittau srittau deleted the requests-encoding branch September 25, 2021 10:46
@srittau srittau mentioned this pull request Sep 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @Akuli