Correct positional-only parameters in datetime.pyi
#6343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all positional-or-keyword parameters in the pure-Python implementation, but positional-only parameters in the C implementation. Thus, passing them as keyword arguments is unreliable, and will result in errors being raised in some situations.
JelleZijlstra
approved these changes
Nov 19, 2021
I created https://bugs.python.org/issue45821, but stopped short of filing a PR, as I wasn't sure if making all the parameters positional-only in the Python implementation would be backwards-compatible -- it might be better to make all the parameters in the C implementation positional-or-keyword? And, uh, I can't write C code (yet) 😢 |
This comment has been minimized.
This comment has been minimized.
|
Oh, that diff is entirely due to the second argument of |
Akuli
reviewed
Nov 19, 2021
This comment has been minimized.
This comment has been minimized.
Akuli
approved these changes
Nov 19, 2021
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all positional-or-keyword parameters in the pure-Python implementation, but positional-only parameters in the C implementation. Thus, passing them as keyword arguments is unreliable, and will result in errors being raised in some situations.