Skip to content

Add forgotten self in urllib #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stdlib/3/urllib/request.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class BaseHandler:
parent = ... # type: OpenerDirector
def add_parent(self, parent: OpenerDirector) -> None: ...
def close(self) -> None: ...
def http_error_nnn(req: Request, fp: IO[str], code: int, msg: int,
def http_error_nnn(self, req: Request, fp: IO[str], code: int, msg: int,
hdrs: Mapping[str, str]) -> _UrlopenRet: ...

class HTTPDefaultErrorHandler(BaseHandler): ...
Expand Down Expand Up @@ -117,9 +117,9 @@ if sys.version_info >= (3, 5):
def add_password(self, realm: str, uri: Union[str, Sequence[str]],
user: str, passwd: str,
is_authenticated: bool = ...) -> None: ...
def update_authenticated(uri: Union[str, Sequence[str]],
def update_authenticated(self, uri: Union[str, Sequence[str]],
is_authenticated: bool = ...) -> None: ...
def is_authenticated(authuri: str) -> bool: ...
def is_authenticated(self, authuri: str) -> bool: ...

class AbstractBasicAuthHandler:
def __init__(self,
Expand Down Expand Up @@ -191,7 +191,7 @@ class URLopener:
def open(self, fullurl: str, data: Optional[bytes] = ...) -> _UrlopenRet: ...
def open_unknown(self, fullurl: str,
data: Optional[bytes] = ...) -> _UrlopenRet: ...
def retrieve(url: str, filename: Optional[str] = ...,
def retrieve(self, url: str, filename: Optional[str] = ...,
reporthook: Optional[Callable[[int, int, int], None]] = ...,
data: Optional[bytes] = ...) -> Tuple[str, Optional[Message]]: ...

Expand Down
2 changes: 1 addition & 1 deletion stdlib/3/urllib/robotparser.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import sys
_RequestRate = NamedTuple('_RequestRate', [('requests', int), ('seconds', int)])

class RobotFileParser:
def __init__(url: str = ...) -> None: ...
def __init__(self, url: str = ...) -> None: ...
def set_url(self, url: str) -> None: ...
def read(self) -> None: ...
def parse(self, lines: Iterable[str]) -> None: ...
Expand Down