Skip to content

Fix allowlists #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix allowlists #6440

merged 1 commit into from
Nov 29, 2021

Conversation

hauntsaninja
Copy link
Collaborator

Broken by #6439

JelleZijlstra
JelleZijlstra approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this happened?

@hauntsaninja
Copy link
Collaborator Author

Yeah, #6408 meant dummy_threading was an unused allowlist for py39 and py310, which made the action remove it. Last I checked, Github Actions doesn't allow running Github Actions on Github Actions, so CI didn't run on #6439. This kind of thing has happened several times before.

@hauntsaninja hauntsaninja merged commit 287a9a4 into python:master Nov 29, 2021
@hauntsaninja hauntsaninja deleted the allow branch November 29, 2021 04:18
@Akuli
Copy link
Collaborator

Akuli commented Nov 29, 2021

I came across this in #6424 before #6439 existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauntsaninja @Akuli @JelleZijlstra