-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Adds bdist_wininst
definition
#7249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stdlib/@python2/distutils/config.pyi
Outdated
@@ -13,5 +13,3 @@ class PyPIRCCommand(Command): | |||
boolean_options: ClassVar[list[str]] | |||
def initialize_options(self) -> None: ... | |||
def finalize_options(self) -> None: ... | |||
@abstractmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also removed several redefinitions of run
abstract method. It is defined in Command
from _typeshed import StrOrBytesPath | ||
from typing import Any, ClassVar | ||
|
||
if sys.version_info < (3, 10): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using this guard, the file should be added to VERSIONS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already there:
Line 116 in 5c309e5
distutils.command.bdist_wininst: 2.7-3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments below 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I see the comments you're referring to, but cf python/mypy#12083
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit d2506c8.
Yes, it failed 🎉 |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We now run stubtest from mypy master with the VERSIONS fix, could you merge master and try removing the version check again? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Done! |
Source: https://github.com/python/cpython/blob/3.9/Lib/distutils/command/bdist_wininst.py
Removed in
3.10