Remove Python 2 support from some third-party distributions #7466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove all Python 2 only third-party distributions. * Remove Python 2 support from six as the Python 2 stubs diverged from the Python 3 stubs. * Recursively remove Python 2 support from all distributions that depend on the distributions above. Affects: * boto * cryptography * enum34 (removed) * ipaddress (removed) * paramiko * pysftp * pyvmomi * six Part of python#7367
srittau
commented
Mar 9, 2022
| f"as all classes implicitly inherit from `object` in Python 3" | ||
| ) | ||
| # Temporarily disable this check for two ex-Python 2 stubs. | ||
| if "paramiko" not in str(path) and "cryptography" not in str(path): |
There was a problem hiding this comment.
I'll send a separate PR once this is merged to fix those problems and re-enable this check.
AlexWaygood
reviewed
Mar 9, 2022
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Mar 9, 2022
Akuli
approved these changes
Mar 9, 2022
|
These stubs are now Python 3 only, and can potentially be cleaned up:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Python 3 stubs.
on the distributions above.
Affects:
Part of #7367