Skip to content

pytz: utcoffset only returns None if dt is None #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2022
Merged

pytz: utcoffset only returns None if dt is None #7510

merged 4 commits into from
Mar 19, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra
Copy link
Member Author

OK I need to do something else here to get the override checks to be happy.

@AlexWaygood
Copy link
Member

Perhaps we need to make the stdlib classes generic first, as per python/mypy#10067.

@JelleZijlstra JelleZijlstra mentioned this pull request Mar 19, 2022
Open
@JelleZijlstra
Copy link
Member Author

I don't think so, I believe it's a mypy bug that it complains about this.

@AlexWaygood AlexWaygood merged commit d9f1f7b into master Mar 19, 2022
@AlexWaygood AlexWaygood deleted the JelleZijlstra-patch-2 branch March 19, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @AlexWaygood