sqlite3: add 3.11 additions #7625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Apr 15, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Apr 16, 2022
| def seek(self, __offset: int, __whence: int = ...) -> None: ... | ||
| def __len__(self) -> int: ... | ||
| def __enter__(self: Self) -> Self: ... | ||
| def __exit__(self, __typ: object, __val: object, __tb: object) -> Literal[False]: ... |
There was a problem hiding this comment.
I think this is going to anger my unreleased Y036 check over at flake8-pyi :/ PyCQA/flake8-pyi@b7f7e9a
There was a problem hiding this comment.
hm, do you think we should change it? This __exit__ method really does take object; that's what the AC annotations say.
There was a problem hiding this comment.
'Kay, I'll work up a patch for flake8-pyi. It should be fine to merge this before flake8-pyi is fixed.
srittau
approved these changes
Apr 16, 2022
AlexWaygood
approved these changes
Apr 16, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite3cpython#30680 (and anticipating that gh-69093: Expose sqlite3.Blob as a class cpython#91550 will be merged)sqlite3connection limits cpython#28463