Skip to content

dateutil.tz.tz: Replace IO with protocols #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 27, 2022
Merged

dateutil.tz.tz: Replace IO with protocols #7717

merged 8 commits into from
Apr 27, 2022

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Apr 27, 2022

No description provided.

@srittau
Copy link
Collaborator Author

srittau commented Apr 27, 2022

In theory, the reader protocol __enter__ methods could return a different object and we could use two protocols, but I decided to ignore that case as it's unlikely to be used in practice.

Akuli
Akuli reviewed Apr 27, 2022
View reviewed changes
@Akuli Akuli merged commit ff2feff into python:master Apr 27, 2022
@srittau srittau deleted the dateutil-io branch April 27, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @Akuli