Cleanup mypy_test.py
#7738
Merged
Cleanup mypy_test.py
#7738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Apr 28, 2022
| @@ -76,7 +74,7 @@ def parse_versions(fname): | |||
| continue | |||
| m = _VERSION_LINE_RE.match(line) | |||
| assert m, "invalid VERSIONS line: " + line | |||
| mod = m.group(1) | |||
| mod: str = m.group(1) | |||
There was a problem hiding this comment.
Interesting, why is this necessary?
There was a problem hiding this comment.
I was running mypy with --strict on this file, and it correctly pointed out that, strictly speaking, mod here could be Any due to this overload:
Line 1091 in c3ebc7e
That then causes issues here due to --warn-any-return, which is part of --strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--warn-unused-ignorescommand-line option (it doesn't work, see mypy --warn-unused-ignores doesn't work #6307).I am planning a second PR after this one, to add new functionality to
mypy_test.pyso that it runs on files in thetestsandtest_casesdirectories.