mypy_test.py: Skip Flask-SQLAlchemy
#7977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't repro, could you confirm whether python/mypy#12324 fixes? |
I'll try to confirm tomorrow if python/mypy#12324 fixes the issue. It happened very consistently for me locally. Deleting the cache sorted it, but it would then just crash again after running |
|
I reproduced the crash on mypy master, and can confirm that python/mypy#12324 appears to fix the issue. |
|
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since we upgraded to mypy 0.960, I've hit python/mypy#11899 every second time I run
mypy_test.pylocally. Mypy always crashes onFlask-SQLAlchemy, so I propose we skipmypy_teston those stubs for now, unless and until python/mypy#12324 is merged.