Skip to content

Type http.client.HTTPConnection.sock #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Type http.client.HTTPConnection.sock #8386

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33d1c1f
Type `http.client.HTTPConnection.sock`
sobolevn Jul 25, 2022
0fb63e6
Update client.pyi
sobolevn Jul 25, 2022
fb57e47
Update client.pyi
sobolevn Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/http/client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class HTTPConnection:
timeout: float | None
host: str
port: int
sock: Any
sock: socket | Any # can be `None` if `.connect()` was not called
def __init__(
self,
host: str,
Expand All @@ -180,6 +180,8 @@ class HTTPConnection:
def send(self, data: _DataType) -> None: ...

class HTTPSConnection(HTTPConnection):
# Can be `None` if `.connect()` was not called:
sock: ssl.SSLSocket | Any # type: ignore[override]
def __init__(
self,
host: str,
Expand Down