Skip to content

Unpin stubtest from 3.10.5 #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Unpin stubtest from 3.10.5 #8523

merged 5 commits into from
Aug 12, 2022

Conversation

AlexWaygood
Copy link
Member

Fixes #8510

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Aug 10, 2022
@AlexWaygood
Copy link
Member Author

We now have 3.10.6 on Ubuntu and MacOS, but still not Windows, so this is deferred until we have it on Windows as well.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member Author

We now have 3.10.6 on Ubuntu and MacOS, but still not Windows, so this is deferred until we have it on Windows as well.

Seems like sometimes setup-python gives us 3.10.6 on Windows, sometimes 3.10.5 ¯\_(ツ)_/¯

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Aug 12, 2022
@AlexWaygood AlexWaygood marked this pull request as ready for review August 12, 2022 07:56
@AlexWaygood
Copy link
Member Author

Looks like we're now getting 3.10.6 consistently on all platforms; I think this is now mergeable!

@AlexWaygood AlexWaygood requested a review from srittau August 12, 2022 07:57
@srittau srittau merged commit 1ec5712 into master Aug 12, 2022
@srittau srittau deleted the 3.10.6 branch August 12, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stubtest failures due to 3.10.6
2 participants