Bump protobuf to 3.20.1 #8609
Bump protobuf to 3.20.1 #8609
Conversation
|
(converting to draft so I can fix stubtest) |
This comment has been minimized.
This comment has been minimized.
There are even newer versions available (4.*), but I had found a bug in it which prevented it from working with mypy-protobuf. For now, sticking to just 3.20.1
nipunn1313
force-pushed
the
bump_protobuf_3_20_only
branch
from
d708b54 to
3908808
Compare
|
I pushed some new code - but the github CI hasn't seemed to rerun yet - not sure what the hold up is. Poking around. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
I think it did re-run? https://github.com/python/typeshed/runs/8015005080?check_suite_focus=true (the later stubtest run) has different errors to the earlier stubtest run (https://github.com/python/typeshed/runs/8014591866?check_suite_focus=true) 🙂 |
|
it just took a while to run. I think there's some limitation where it waits for the previous run to fully complete before starting another run. |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Ok looks like it completed successfully! |
| @@ -11,7 +11,7 @@ set -ex -o pipefail | |||
| # followed by committing the changes to typeshed | |||
| # | |||
| # Update these two variables when rerunning script | |||
| PROTOBUF_VERSION=3.19.3 | |||
| PROTOBUF_VERSION=3.20.1 | |||
| MYPY_PROTOBUF_VERSION=v3.2.0 | |||
There was a problem hiding this comment.
| MYPY_PROTOBUF_VERSION=v3.2.0 | |
| MYPY_PROTOBUF_VERSION=v3.3.0 |
There was a problem hiding this comment.
yes, but I'd like to do it separately - because it ends up having a pretty different set of changes.
I originally was preparing a PR that did both all at once, but it ends up with a bunch of different changes since it changes the code-generator utility.
Would prefer to keep the two PRs isolated.
There was a problem hiding this comment.
I was also planning to test the changes with 3.3.0 and if things don't work out perfectly, I may have to release 3.3.1 (or 3.4.0) to get typeshed to work.
| @@ -1,2 +1,2 @@ | |||
| version = "3.19.*" | |||
| version = "3.20.*" | |||
| extra_description = "Generated with aid from mypy-protobuf v3.2.0" | |||
There was a problem hiding this comment.
| extra_description = "Generated with aid from mypy-protobuf v3.2.0" | |
| extra_description = "Generated with aid from mypy-protobuf v3.3.0" |
|
sweet! Will send you another one updating mypy-protobuf too! |
There are even newer versions available (4.*), but I had found a bug
in it which prevented it from working with mypy-protobuf. For now,
sticking to just 3.20.1 until that stuff is resolved.