Add missing attributes for docutils.io #8716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyreese
force-pushed
the
docutils-io
branch
2 times, most recently
from
044b563 to
b9ad6ab
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
amyreese
added a commit
to phofl/sphinx-mdinclude
that referenced
this pull request
Sep 9, 2022
amyreese
added a commit
to phofl/sphinx-mdinclude
that referenced
this pull request
Sep 9, 2022
AlexWaygood
requested changes
Sep 9, 2022
This comment has been minimized.
This comment has been minimized.
`error_string` and `ErrorOutput` were added in `v0.19`. Fills out some missing pieces of `Input` and `FileInput` as well.
amyreese
force-pushed
the
docutils-io
branch
from
3a0f384 to
9ed6f72
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@AlexWaygood Thank you for the pointers! All have been applied now. |
AlexWaygood
reviewed
Sep 11, 2022
AlexWaygood
reviewed
Sep 11, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Sep 11, 2022
There was a problem hiding this comment.
Thanks @amyreese! I pushed two more additional fixes to this PR, everything looks good now 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error_stringandErrorOutputwere added inv0.19. Fills out some missing pieces ofInputandFileInputas well.