Skip to content

google-cloud-ndb: drop dependency on types-six #8793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2022
Merged

google-cloud-ndb: drop dependency on types-six #8793

merged 1 commit into from
Sep 27, 2022

Conversation

hauntsaninja
Copy link
Collaborator

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja mentioned this pull request Sep 26, 2022
Merged
AlexWaygood
AlexWaygood approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have some kind of lint detecting entirely unused dependencies

stubs/google-cloud-ndb/METADATA.toml
@@ -1,2 +1,2 @@
version = "1.11.*"
requires = ["types-six"]
requires = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires = []

@hauntsaninja hauntsaninja merged commit 9544447 into python:master Sep 27, 2022
@hauntsaninja hauntsaninja deleted the gcndb-six branch September 27, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @AlexWaygood