Skip to content

Run stub_uploader tests in CI #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

hauntsaninja
Copy link
Collaborator

stub_uploader is developing a bunch of validation, a lot of which must live in that repo for security reasons. We don't want to find out about this validation failing when stub uploading fails.

We also run it in the daily test since there are some checks that (unfortunately, albeit unlikely) can be broken by new upstream releases.

This is blocked on typeshed-internal/stub_uploader#60

stub_uploader is developing a bunch of validation, a lot of which must
live in that repo for security reasons. We don't want to find out about
this validation failing when stub uploading fails.

We also run it in the daily test since there are some checks that
(unfortunately, albeit unlikely) can be broken by new upstream releases.

This is blocked on typeshed-internal/stub_uploader#60
@hauntsaninja hauntsaninja marked this pull request as ready for review September 28, 2022 07:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Very minor: The name of the part of the GH Actions job where we actually run the tests is currently cd stub_uploader)

hauntsaninja and others added 2 commits September 29, 2022 22:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Alex Waygood <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Alex Waygood <[email protected]>
@hauntsaninja hauntsaninja merged commit d7a7013 into python:master Sep 30, 2022
@hauntsaninja hauntsaninja deleted the test-stub-upload branch September 30, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants