Skip to content

stubsabot: only update existing branches if the diff relative to master would be different #8854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

AlexWaygood
Copy link
Member

Currently, if there are no non-stubsabot commits on a stubsabot branch associated with an open PR, stubsabot will force-push to that branch on a daily basis to update the PR.

This PR proposes tweaking that logic so that stubsabot will only update the PR branch if it would change the diff between the PR and master.

@JelleZijlstra JelleZijlstra merged commit aeb16b1 into python:master Oct 6, 2022
@AlexWaygood AlexWaygood deleted the stubsabot-force-pushes branch October 6, 2022 00:35
@AlexWaygood
Copy link
Member Author

Confirmed that stubsabot is still updating open PRs where necessary: see #8849 for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants