Skip to content

asyncore and asynchat will be removed in 3.12 #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2023

Conversation

sobolevn
Copy link
Member

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last version in the "version ranges" in this file is the "last version when the module was available" :)

@AlexWaygood
Copy link
Member

I'm also not sure if we should do this before the runtime PR's been merged? But don't have a strong opinion either way on that.

@AlexWaygood AlexWaygood dismissed their stale review October 29, 2022 11:41

Changes made

@github-actions

This comment has been minimized.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Oct 29, 2022

I think stubtest might not complain about missing stubs for stdlib modules, so this is best done when betas are released (in case the removal is undone)

@AlexWaygood
Copy link
Member

I think stubtest might not complain about missing stubs for stdlib modules

That's correct, it doesn't

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Oct 29, 2022
@AlexWaygood AlexWaygood marked this pull request as draft October 30, 2022 11:07
@AlexWaygood AlexWaygood changed the title asyncore and asynchat will be removed in 3.12 [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12 Oct 31, 2022
@sobolevn sobolevn removed the status: deferred Issue or PR deferred until some precondition is fixed label May 23, 2023
@sobolevn sobolevn marked this pull request as ready for review May 23, 2023 16:34
@sobolevn sobolevn changed the title [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12 asyncore and asynchat will be removed in 3.12 May 23, 2023
@sobolevn
Copy link
Member Author

Beta 1 is out! 👍

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit e666602 into python:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants