Fix issue #9296 (calling register on KeysView subclass causes false positive error) #9348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jab
force-pushed
the
bugfix-issue-9296
branch
2 times, most recently
from
054972b to
5a3169c
Compare
This comment has been minimized.
This comment has been minimized.
jab
force-pushed
the
bugfix-issue-9296
branch
from
313022b to
69e36c1
Compare
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Dec 10, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #9296, this PR reverts the commits in #8977 and #9058 that resulted in false positive errors when e.g. calling register() on a KeysView subclass, until a non-buggy implementation is landed. This also adds a regression test.