Missing special attributes of class instances inherited from object #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rerunning travis. |
ambv
reviewed
Feb 20, 2017
stdlib/2/__builtin__.pyi
Outdated
| @@ -44,6 +45,8 @@ class object: | |||
| def __getattribute__(self, name: str) -> Any: ... | |||
| def __delattr__(self, name: str) -> None: ... | |||
| def __sizeof__(self) -> int: ... | |||
| def __reduce__(self) -> Union[str, tuple]: ... | |||
There was a problem hiding this comment.
You used Union as a return type. In Mypy, this means that code that uses values returned from this method will trigger errors if the usage is valid for a single type only. This is why in general we're avoiding using Unions as return values.
Is this intended, @vlasovskikh?
There was a problem hiding this comment.
@ambv You're right. object.__reduce__ always returns a tuple unless it's overridden in inheritors. So inheritors are free to specify str or tuple or a specific tuple as the actual return type of the override.
It's up to its inheritors to return either a tuple or a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This this the follow-up to PR #874 with the non-controversial changes to
object.