3rd-party stubtest: use MYPYPATH for internal dependencies #9512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Jan 12, 2023
Avasam
reviewed
Dec 29, 2024
|
|
||
| return True | ||
|
|
||
|
|
||
| def print_commands(dist: Path, pip_cmd: list[str], stubtest_cmd: list[str]) -> None: | ||
| def print_commands(dist: Path, pip_cmd: list[str], stubtest_cmd: list[str], mypypath: str) -> None: |
There was a problem hiding this comment.
@AlexWaygood The dist argument after this change has been left unused. Was that intentional ?
There was a problem hiding this comment.
Nope! It makes sense to get rid of it :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we're running stubtest on our stubs for
caldav, wepip installall the requirements fortypes-caldavinto the virtual environment before running the test. However, for typeshed-internal requirements, this is unnecessary: we can add the typeshed-internal requirements forcaldavto MYPYPATH instead. This has two advantages:pip installing stuff is slow; this should be faster. Some of our stubs have a lot of internal dependencies: when testingcaldav, we currently have topip installtypes-requests,types-urllib3andtypes-vobject.