Python 2.7 support #164
Merged
Python 2.7 support #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python 2 port is located in python2/. Other options were: * Having a separate branch for Python2 => cannot create a single typing package for PyPI * Storing a diff file for Python 2 and apply a patch when creating a source package => hard to do on Windows and CI servers The current approach requires applying new changes in src/ to python2/ manually or patching python2/ with diffs from commits. get_type_hints() does nothing and it is untested, since there are no __annotations__ for functions in Python 2. _root=True backported as the TypingMeta.assert_no_subclassing() check that you have to call explicitly.
|
Fixes #160. |
|
Conflicts are due to the removal of unused imports on current master, should be easy to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes in the backport to Python 2.7. Please review the 2aa1374 commit. It's the diff between Python 2 and 3.