Skip to content

Try fixing Travis build #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2019
Merged

Try fixing Travis build #666

merged 5 commits into from
Aug 10, 2019

Conversation

ilevkivskyi
Copy link
Member

No description provided.

@ilevkivskyi ilevkivskyi force-pushed the fix-ci-pyver branch 2 times, most recently from 2b362a8 to 5074699 Compare August 7, 2019 17:18
@ilevkivskyi
Copy link
Member Author

@gvanrossum This fixes the red master (something changed in Travis environment). The fix also discovered that flake8 was not run for long time, so I also fix it.

Could you please take a look?

@gvanrossum
Copy link
Member

gvanrossum commented Aug 8, 2019 via email

brugz
brugz reviewed Aug 9, 2019
View reviewed changes
Copy link

@brugz brugz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is my first Code Review on GitHub, so please be kind (or unkind).

Whats the #noqa tag actually doing?

@gvanrossum
Copy link
Member

Whats the #noqa tag actually doing?

That's indicating to linters (e.g. flake8, pylint) that they should not complain about that line. There are several tests that intentionally put bad code in a string type annotation or in a type comment (to verify that the typing module handles these correctly), and some linters are smart enough to look inside type comments or string annotations and complain, making the build fail. So the # noqa shuts up the linter and so the build passes.

gvanrossum
gvanrossum reviewed Aug 10, 2019
View reviewed changes
@ilevkivskyi ilevkivskyi merged commit 00522c4 into master Aug 10, 2019
@ilevkivskyi ilevkivskyi deleted the fix-ci-pyver branch August 10, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael0x2a Michael0x2a Michael0x2a left review comments

@gvanrossum gvanrossum gvanrossum left review comments

@brugz brugz brugz left review comments

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilevkivskyi @gvanrossum @Michael0x2a @brugz @the-knights-who-say-ni