Skip to content

Update setup.py #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Update setup.py #784

merged 2 commits into from
Mar 1, 2021

Conversation

dciborow
Copy link
Contributor

We got this package by mistake because the upper pin for Python is not set. The dataclasses package is a similar backport, but contains this pin.
https://github.com/ericvsmith/dataclasses

We got this package by mistake because the upper pin for Python is not set. The dataclasses package is a similar backport, but contains this pin.
https://github.com/ericvsmith/dataclasses
@the-knights-who-say-ni

This comment has been minimized.

@dciborow
Copy link
Contributor Author

not sure how to reboot the CLA check, but i have since signed the agreement.

@gvanrossum
Copy link
Member

Honestly, maybe we should just limit this to 2.7 and 3.4? Note the comment stating that for 3.5 and up you need to upgrade Python. That’s because the stdlib has higher priority than sites-packages.

The CLA takes 1-2 business days, you have to click on “check yourself”.

@dciborow
Copy link
Contributor Author

#785

@dciborow
Copy link
Contributor Author

@gvanrossum , updated to "<3.5". I thought this was the a little cleaner then <=3.4.*?

Checked CLA, not yet...

@dciborow
Copy link
Contributor Author

fixed the first part of CELA request, (have bugs account, now pending CELA sig)

@gvanrossum
Copy link
Member

What's CELA? A misspelling of CLA? Or some variant that I don't know about?

@dciborow
Copy link
Contributor Author

dciborow commented Feb 19, 2021

@gvanrossum , sorry "CELA" is our internal word for everything legal >.<. My fingers type python better then English.

Misspelling of CLA. Which looks good now.

@gvanrossum gvanrossum merged commit c487c47 into python:master Mar 1, 2021
@dciborow dciborow deleted the patch-1 branch March 1, 2021 23:59
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants