Skip to content

Adding SaltStack #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

garethgreenaway
Copy link
Contributor

SaltStack will not be supporting Python 2.x as of January 1, 2020 --and, at the time of this post, had over 9,800 stars on GitHub. Happy to adjust placement in the list!

…and, at the time of the this post, had over 9,800 stars on GitHub. Happy to adjust placement in the list!
@thatch45
Copy link

Hi, as the creator of Salt, I approve this pull request :)

@takluyver
Copy link
Member

Thanks!

It looks like there are several other active maintainers now - are they on board with putting Salt's name on this? I'm not doubting you, we just try to make sure that no-one gets a surprised by a project they feel part of signing the statement.

@Ch3LL
Copy link

Ch3LL commented Apr 25, 2019

👍 from me

@garethgreenaway
Copy link
Contributor Author

@takluyver I am a member of the SaltStack core team that is responsible for maintaining the Salt project, I've also asked other members of the team to comment on this. 🙂 We've also had a lengthy discussion with our community about dropping support for python 2 and the community is on board.

@waynew
Copy link

waynew commented Apr 25, 2019

👍 Yes indeed! Python 2 was a great language that made the world a better place, but Python 3 is even better, and it's time for new versions of SaltStack to go Python3 only ❤️ 🚀 🌔

✨ 🐍 ✨

@s0undt3ch
Copy link

👍
Long Live Python 3!

@twangboy
Copy link

Python 2 has been great, but it's time to move on.

@thatch45
Copy link

This move has been proposed and ratified by the SaltStack core engineering team and community in a Salt Enhancement Proposal:
https://github.com/saltstack/salt-enhancement-proposals/blob/master/accepted/0005-retire-py2-support.md

All deprecation warnings have been added to released software and release notes have made these announcements.
I appreciate your diligence in making sure we are all on board here!

@Carreau
Copy link
Member

Carreau commented Apr 25, 2019

Thanks !

Make sure to look at the practicalities page and in particular how to put python_requires in your setup.py, to make sure pip does not try to install newer versions of salt on old python. After all we still care about Python 2 users as many are stuck there, and would still like pip install to work form them !

@takluyver
Copy link
Member

Thanks all, I think it looks like there's a clear consensus. :-)

@takluyver takluyver merged commit 97e13ef into python3statement:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants