Skip to content

Add sentencepiece tokenizer support to llm runner #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

larryliu0820
Copy link
Contributor

Summary:
Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Differential Revision: D76789606

Pulled By: larryliu0820

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

larryliu0820 added a commit that referenced this pull request Jun 17, 2025
Summary:

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Differential Revision: D76789606

Pulled By: larryliu0820
larryliu0820 added a commit to pytorch/executorch that referenced this pull request Jun 17, 2025
Summary:
X-link: pytorch-labs/tokenizers#85

Fixes #11618

Add sentencepiece tokenizer support

Pull Request resolved: #11645

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

larryliu0820 added a commit that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: #85

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Differential Revision: D76789606

Pulled By: larryliu0820
facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2025
Summary:

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

larryliu0820 added a commit to pytorch/executorch that referenced this pull request Jun 17, 2025
Summary:
X-link: pytorch-labs/tokenizers#85

Fixes #11618

Add sentencepiece tokenizer support

Pull Request resolved: #11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2025
Summary:

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

larryliu0820 added a commit that referenced this pull request Jun 17, 2025
Summary:

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

larryliu0820 added a commit that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: #85

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
larryliu0820 added a commit to pytorch/executorch that referenced this pull request Jun 17, 2025
Summary:
X-link: pytorch-labs/tokenizers#85

Fixes #11618

Add sentencepiece tokenizer support

Pull Request resolved: #11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
larryliu0820 added a commit to pytorch/executorch that referenced this pull request Jun 19, 2025
Summary:
X-link: pytorch-labs/tokenizers#85

Fixes #11618

Add sentencepiece tokenizer support

Pull Request resolved: #11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

Summary:

Fixes pytorch/executorch#11618

Add sentencepiece tokenizer support

X-link: pytorch/executorch#11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789606

larryliu0820 added a commit to pytorch/executorch that referenced this pull request Jun 19, 2025
Summary:
X-link: pytorch-labs/tokenizers#85

Fixes #11618

Add sentencepiece tokenizer support

Pull Request resolved: #11645

Reviewed By: guangy10

Differential Revision: D76789606

Pulled By: larryliu0820
@facebook-github-bot facebook-github-bot merged commit 6eb0839 into main Jun 20, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime crash in PreTokenizer when running optimum-et generated gemma3 via llama runner
3 participants