Skip to content

SD2 inference pass mesh for flahattention with spmd #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

ManfeiBai
Copy link
Contributor

@ManfeiBai ManfeiBai commented Jan 28, 2025

What does this PR do?

SD2 inference pass mesh for flahattention with spmd

tested log: https://gist.github.com/ManfeiBai/bc97938b94b7b8b2264e6d9dcbae0f26

Before submitting

@ManfeiBai ManfeiBai requested a review from zpcore January 28, 2025 21:46
@zpcore
Copy link
Collaborator

zpcore commented Jan 28, 2025

Can you run ruff check --fix src to fix the format? Thanks

@ManfeiBai
Copy link
Contributor Author

ManfeiBai commented Jan 28, 2025

Can you run ruff check --fix src to fix the format? Thanks

thanks, updated

@ManfeiBai ManfeiBai requested a review from zpcore January 28, 2025 22:09
@ManfeiBai
Copy link
Contributor Author

hi, @zpcore, current CI failure in https://github.com/pytorch-tpu/diffusers/actions/runs/13020451508/job/36320882664?pr=12 and https://github.com/pytorch-tpu/diffusers/actions/runs/13020451508/job/36320882664?pr=12 are due to code-not-used or format issue from other not-related code file;

to avoid touch unrelated project in this simple PR, will propose to merge PR with these CI failure

Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing

@zpcore zpcore merged commit 637da5a into pytorch-tpu:main Jan 28, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants