move memory copy into one_shot_all_reduce #2770
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58223358 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D58223358 |
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 22, 2024
Summary: Pull Request resolved: pytorch#2770 Avoid latency of launching hipMemcpyAsync. Could see 3-4us reduction in benchmarking. Also see improvements in end to end testing. Reviewed By: sryap, jianyuh Differential Revision: D58223358
xw285cornell
force-pushed
the
export-D58223358
branch
from
817914f to
ddea866
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58223358 |
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 22, 2024
Summary: Pull Request resolved: pytorch#2770 Avoid latency of launching hipMemcpyAsync. Could see 3-4us reduction in benchmarking. Also see improvements in end to end testing. Reviewed By: sryap, jianyuh Differential Revision: D58223358
xw285cornell
force-pushed
the
export-D58223358
branch
from
ddea866 to
5953c41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58223358 |
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 22, 2024
Summary: Pull Request resolved: pytorch#2770 Avoid latency of launching hipMemcpyAsync. Could see 3-4us reduction in benchmarking. Also see improvements in end to end testing. Reviewed By: sryap, jianyuh Differential Revision: D58223358
xw285cornell
force-pushed
the
export-D58223358
branch
from
5953c41 to
9bed3d1
Compare
Summary: Pull Request resolved: pytorch#2770 Avoid latency of launching hipMemcpyAsync. Could see 3-4us reduction in benchmarking. Also see improvements in end to end testing. Reviewed By: sryap, jianyuh Differential Revision: D58223358
|
This pull request was exported from Phabricator. Differential Revision: D58223358 |
xw285cornell
force-pushed
the
export-D58223358
branch
from
9bed3d1 to
3b52730
Compare
|
This pull request has been merged in 7f77444. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Avoid latency of launching hipMemcpyAsync. Could see 3-4us reduction in benchmarking. Also see improvements in end to end testing.
Moved from #2693 to fix some formatting issue. Thanks @wenkaidu for contributing.
Reviewed By: sryap, jianyuh
Differential Revision: D58223358