OSS MPZCH CUDA kernel in FBGEMM #4214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for pytorch-fbgemm-docs failed.
|
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
684b319 to
a29cd2a
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
a29cd2a to
2c3846e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
2c3846e to
2b54f80
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
2b54f80 to
d94acaa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
d94acaa to
3d36968
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
3d36968 to
a273543
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
a273543 to
d203230
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
d203230 to
4490476
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
4490476 to
e35f85d
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
cf2c33f to
c1de98c
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
c1de98c to
7565873
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
7565873 to
b2812ca
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
b2812ca to
138ce61
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
138ce61 to
2849f31
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
2849f31 to
ff9ea8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
ff9ea8e to
62db371
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
lizhouyu
force-pushed
the
export-D75505020
branch
from
62db371 to
3bba1db
Compare
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Reviewed By: ionuthristodorescu Differential Revision: D75505020
|
This pull request was exported from Phabricator. Differential Revision: D75505020 |
lizhouyu
force-pushed
the
export-D75505020
branch
from
3bba1db to
e39d109
Compare
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020 Reviewed By: ionuthristodorescu
lizhouyu
added a commit
to lizhouyu/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4214 X-link: facebookresearch/FBGEMM#1290 Opensource FBGEMM CUDA Kernel for MPZCH feature ### Major changes - Create a folder named `faster_hash` under the `fbgemm/fbgemmgpu/src` folder. - Copy the following files to the created folder from `fbsource/fbcode/caffe2/torch/fb/retrieval` - faster_hash.cpp - faster_hash.cu - common_utils.cuh - Revise the `faster_hash.cpp` - Change `namespace fb` to `namespace fbgemm_gpu`. - Comment out `using namespace torch::fb::turborec;` - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `faster_hash.cu` - Change `namespace fb` to `namespace fbgemm_gpu`. - Change `TORCH_LIBRARY_IMPL(fb, ...)` to `TORCH_LIBRARY_IMPL(fbgemm, ...)` - Fix namespace calling issue due to the namespace change. - Revise the `common_utils.cuh` file - Change `namespace fb` to `namespace fbgemm_gpu`. - Add a BUCK file to compile the cpp and cuda library. - Copy the `faster_hash_test.py` file to the `fbgemm/fbgemm_gpu/test` folder. - Add a section in the BUCK file under the `test` folder for `python_unittest` of `faster_hash_test`. - In the `faster_hash_test.py` file - Load the `faster_hash` related libraries with `torch.ops.load` API. - Replace all the `torch.ops.fb` to `torch.ops.fbgemm`. - Following other test files to add `opensource` and `gpu availability` check. ### Questions - After refactorying, the API calls `torch.ops.create_zch_buffer`, `torch.ops.zero_collision_hash`, `torch.ops.fbgemm.zero_collision_hash`, and `torch.ops.fbgemm.create_zch_buffer` are all valid, while `torch.ops.create_zch_buffer` and `torch.ops.zero_collision_hash` may incur certain parameter mismatches. How to resolve this issue and disable the API calls without `fbgemm`? - How to integrate the refactoryed library into fbgemm so the test can call something like `from fbgemm_gpu import create_zch_buffer, zero_collision_hash`? Differential Revision: D75505020 Reviewed By: ionuthristodorescu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Opensource FBGEMM CUDA Kernel for MPZCH feature
Major changes
faster_hashunder thefbgemm/fbgemmgpu/srcfolder.fbsource/fbcode/caffe2/torch/fb/retrievalfaster_hash.cppnamespace fbtonamespace fbgemm_gpu.using namespace torch::fb::turborec;TORCH_LIBRARY_IMPL(fb, ...)toTORCH_LIBRARY_IMPL(fbgemm, ...)faster_hash.cunamespace fbtonamespace fbgemm_gpu.TORCH_LIBRARY_IMPL(fb, ...)toTORCH_LIBRARY_IMPL(fbgemm, ...)common_utils.cuhfilenamespace fbtonamespace fbgemm_gpu.faster_hash_test.pyfile to thefbgemm/fbgemm_gpu/testfolder.testfolder forpython_unittestoffaster_hash_test.faster_hash_test.pyfilefaster_hashrelated libraries withtorch.ops.loadAPI.torch.ops.fbtotorch.ops.fbgemm.opensourceandgpu availabilitycheck.Questions
torch.ops.create_zch_buffer,torch.ops.zero_collision_hash,torch.ops.fbgemm.zero_collision_hash, andtorch.ops.fbgemm.create_zch_bufferare all valid, whiletorch.ops.create_zch_bufferandtorch.ops.zero_collision_hashmay incur certain parameter mismatches. How to resolve this issue and disable the API calls withoutfbgemm?from fbgemm_gpu import create_zch_buffer, zero_collision_hash?Differential Revision: D75505020