Creating RocksDBCheckpointHandler to expose rocksdb checkpoint to python #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D75489849 |
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
force-pushed
the
export-D75489849
branch
from
234ec36 to
4e573ea
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
force-pushed
the
export-D75489849
branch
from
4e573ea to
7862394
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
|
This pull request was exported from Phabricator. Differential Revision: D75489849 |
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: Pull Request resolved: pytorch#4224 X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
force-pushed
the
export-D75489849
branch
from
7862394 to
a9a5f8e
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
force-pushed
the
export-D75489849
branch
from
a9a5f8e to
0f230e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75489849 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D75489849 |
Raahul46
force-pushed
the
export-D75489849
branch
from
0f230e0 to
ab31efd
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: Pull Request resolved: pytorch#4224 X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
added 3 commits
June 5, 2025 10:29
Differential Revision: D75489819
Differential Revision: D75489827
Differential Revision: D75489841
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
force-pushed
the
export-D75489849
branch
from
ab31efd to
5a3ae1f
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
Raahul46
force-pushed
the
export-D75489849
branch
from
5a3ae1f to
eac1779
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
|
This pull request was exported from Phabricator. Differential Revision: D75489849 |
Raahul46
force-pushed
the
export-D75489849
branch
from
eac1779 to
2a4bf51
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…hon (pytorch#4224) Summary: Pull Request resolved: pytorch#4224 X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
…hon (pytorch#4224) Summary: Pull Request resolved: pytorch#4224 X-link: facebookresearch/FBGEMM#1302 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. Creating a RocksDBCheckpointHandlerWrapper class to expose the rocksdb checkpoint to python 2. Adding a checkpointhandle attribute to the KVTensorWrapper 3. Adding changes in the training loop to accommodate creation of KVTensor with checkpointHandle Reviewed By: duduyi2013 Differential Revision: D75489849
|
This pull request was exported from Phabricator. Differential Revision: D75489849 |
Raahul46
force-pushed
the
export-D75489849
branch
from
2a4bf51 to
dfa7ada
Compare
|
This pull request has been merged in 05763d3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1302
Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54
Context:
We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold
In this diff:
Differential Revision: D75489849