Skip to content

feat/fix: Add support for general-purpose function exclusion in Dynamo #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat/fix: Add support for general-purpose function exclusion in Dynamo #1968

wants to merge 4 commits into from

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jun 1, 2023 •
edited
Loading

Description

  • Add functionality for advanced exclusion of both function and module-type nodes in Torch-TRT
  • Add sample exclusion for torch.einsum function which can be accelerated as a single unit via TRT
  • Add utilities and improve module and function-level exclusion mechanisms
  • Add test cases for new exclusion mechanism

Note: Dependent on #1921. Do not merge before. For changes unique to this PR see: 356ed0a

Fixes #1959

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

gs-olive added 3 commits May 26, 2023 10:06
@gs-olive
feat: Prototype Module-Acceleration in Dynamo
ee05b59 
- Add support for excluding entire Torch modules from tracing in Dynamo
using Torch custom operators
- Develop new dataclass to store required replacement functions and
operators in a streamlined way
- Add new registry to store mapping between replacement operators and
their corresponding dataclass
- Add documentation for easy additions of new module-level exclusion
operators
@gs-olive
fix: Refactor code and add testing
60df50e
@gs-olive
fix: Address review comments
af53282 
- Fix typing issues, add depedencies to `setup.py`, add qualified name
checking for module registry
@gs-olive gs-olive added WIP Work is in progress, pull request should not be merged yet component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jun 1, 2023
@gs-olive gs-olive self-assigned this Jun 1, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jun 1, 2023
@github-actions github-actions bot requested review from narendasan June 1, 2023 01:51
@gs-olive
fix: Add support for general-purpose exclusion
356ed0a 
- Add functionality for advanced exclusion of both function and
module-type nodes in Torch-TRT
- Add sample exclusion for `torch.einsum` function which can be
accelerated as a single unit via TRT
- Add utilities and improve module and function-level exclusion
mechanisms
- Add test cases for new exclusion mechanism
@gs-olive gs-olive force-pushed the dynamo_general_exclusion branch from 7c3a7cb to 356ed0a Compare June 1, 2023 01:57
@gs-olive
Copy link
Collaborator Author

gs-olive commented Jun 5, 2023

Closed in place of #1980

@gs-olive gs-olive closed this Jun 5, 2023
@gs-olive gs-olive deleted the dynamo_general_exclusion branch June 5, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path WIP Work is in progress, pull request should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[Feature] Exclude key functions from tracing during AOT
2 participants
@gs-olive @facebook-github-bot