fix: Repair argument passing in both Dynamo paths #1997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-olive
added
the
component: dynamo
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
narendasan
reviewed
Jun 7, 2023
gs-olive
force-pushed
the
dynamo_arg_issues
branch
from
acbc3ff to
b97e5c4
Compare
peri044
reviewed
Jun 13, 2023
| @@ -48,7 +48,11 @@ def compile( | |||
| save_timing_cache=False, | |||
| cuda_graph_batch_size=-1, | |||
| is_aten=False, | |||
| explicit_batch_dimension=True, | |||
There was a problem hiding this comment.
Maybe we can remove this flag altogether ? . It is deprecated in TRT and not present in Torchscript.
There was a problem hiding this comment.
Do you think it should be removed from all of the FX code or only the Dynamo FX code?
There was a problem hiding this comment.
Removed all references to explicit_batch_dimension (deprecated to not use) and explicit_precision (has no effect), within the Dynamo code.
- Pass-through new TRT args in export - Pass-through build failures arg in compile - Remove deprecated options including `explicit_batch_dimension` and `explicit_precision` from Dynamo utilities and update references to those options in settings
gs-olive
force-pushed
the
dynamo_arg_issues
branch
from
b97e5c4 to
f8bab8f
Compare
gs-olive
commented
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fx_ts_compatwhereexplicit_batch_dimensiondid not exist in input argsType of change
Please delete options that are not relevant and/or add your own.
Checklist: