Skip to content

fix: Set dynamic=False in torch.compile call #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: Set dynamic=False in torch.compile call #2240

merged 1 commit into from
Aug 22, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Currently, we do not support symbolic values in our converters or in our compiler generally
  • Setting dynamic=False ensures the kernels and shapes are specialized, which is the existing behavior reflected by the current converters
  • When SymInt Dynamic shape support is ready, remove this argument

Addresses one issue in compilation of #1697 with torch_compile

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from peri044 August 17, 2023 21:10
@gs-olive gs-olive self-assigned this Aug 17, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Aug 17, 2023
@gs-olive
fix: Set dynamic=False in torch.compile call
1f7f8e9 
- Currently, we do not support symbolic values in our converters or in
our compiler generally
- Setting `dynamic=False` ensures the kernels and shapes are
specialized, which is the existing behavior reflected by the current
converters
- When SymInt Dynamic shape support is ready, remove this argument
@gs-olive gs-olive force-pushed the dynamic_false_torch_compile branch from cf6c0e8 to 1f7f8e9 Compare August 17, 2023 23:55
peri044
peri044 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

narendasan
narendasan approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 1133432 into pytorch:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 peri044 approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gs-olive @narendasan @peri044 @facebook-github-bot