Skip to content

feat: allow specifying output_dtypes in tests #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zewenli98
Copy link
Collaborator

Description

Allow specifying output_dtypes in run_test(). For some ops whose output is type float but it should be bool to match with pytorch in test. Thus, we need this arg to specify output type.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gs-olive
Copy link
Collaborator

@zewenli98 - should just need a rebase, then is good to go

@zewenli98
Copy link
Collaborator Author

zewenli98 commented Aug 31, 2023

@gs-olive We don't need to do this any more because it's already been merged in my previous PR #2246

@zewenli98 zewenli98 closed this Aug 31, 2023
@zewenli98 zewenli98 deleted the add_output_dtypes branch August 31, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants