Skip to content

feat: support deconv (1d, 2d, and Nd) dynamo converter #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

Support deconv (1d, 2d, and Nd) dynamo converter.

Fixes #2207

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Sep 22, 2023
@github-actions github-actions bot requested a review from gs-olive September 22, 2023 00:36
@zewenli98 zewenli98 self-assigned this Sep 22, 2023
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Could you also add decorators for conv_transposeNd, as here, since these seem to be supported with the new implementation.

@zewenli98
Copy link
Collaborator Author

Sure! Actually I've implemented conv_transposeNd but when I did test I found they were not used while converting. For testing, do you know which PyTorch ops corresponds to these converters?

@gs-olive
Copy link
Collaborator

I would guess the ConvTransposeND like this operator, but these also may just end up as convolution with the boolean transpose specified. If it is not worthwhile with the argument schemas to add conv_transposeNd, then we can add a lowering pass for these

@zewenli98
Copy link
Collaborator Author

these also may just end up as convolution with the boolean transpose specified.

Yes, I found it ends up as convolution with the boolean transpose specified. That's why I didn't add conv_transposeNd. If adding conv_transposeNd, since the args are different, we need to add a new function instead of decorators. Or, just like you said, do it in lowering phase.

Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gs-olive gs-olive merged commit 251405d into pytorch:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose IDeconvolutionLayer in dynamo.conversion.impl
3 participants