Skip to content

fix: type error in embedding_bag #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: type error in embedding_bag #2418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions py/torch_tensorrt/dynamo/conversion/impl/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def embedding_bag(

# TODO: support 2D inputs
# indices = impl.shuffle.reshape(ctx, target, source_ir, f"{name}_reshape_indices", indices, (-1,))

reduce_name = ""
if mode == 0: # sum
reduce_op = functools.partial(
impl.reduce.sum, ctx=ctx, target=target, source_ir=source_ir
Expand Down Expand Up @@ -143,7 +143,6 @@ def embedding_bag(
# however, pytorch doc says if `include_last_offset` is True, the size of offsets
# is equal to the number of bags + 1. The last element is the size of the input,
# or the ending index position of the last bag (sequence).

offsets[-1] = indices.shape[0]

# separately reduce embeddings for different bags
Expand All @@ -158,8 +157,8 @@ def embedding_bag(
f"{name}_slice_embed_{i}",
embed,
0,
offsets[i],
offsets[i + 1],
int(offsets[i]),
int(offsets[i + 1]),
1,
)
reduced_sliced_embed = reduce_op(
Expand Down