Skip to content

Conversation

zewenli98
Copy link
Collaborator

Description

Support 1d ITensor offsets for embedding_bag converter.
Note that this is only for 1d inputs.

There's a bug that same offsets with different types (tensor or ITensor) when include_last_offset=True will give different results. I doubt this is a bug from PyTorch, I'm still investigating it.

Fixes #2345

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Mar 8, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: build system Issues re: Build system component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 8, 2024
@github-actions github-actions bot requested a review from gs-olive March 8, 2024 01:09
@zewenli98 zewenli98 removed component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: build system Issues re: Build system component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 8, 2024
@zewenli98 zewenli98 closed this Mar 8, 2024
@zewenli98
Copy link
Collaborator Author

This PR messed up. Let's use this PR: #2677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: converters Issues re: Specific op converters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement embedding bag convertor
3 participants