Skip to content

Conversation

gs-olive
Copy link
Contributor

@gs-olive gs-olive commented Apr 23, 2024

Description

  • Remove references to network.has_implicit_batch_dimension for TRT 10
  • Default network.has_implicit_batch_dimension=False

Type of change

  • Remove deprecated code

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • Validated in CI
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Apr 23, 2024
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 23, 2024
@github-actions github-actions bot requested a review from apbose April 23, 2024 16:21
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 84fa0b2 into pytorch:release/2.3 Apr 23, 2024
@gs-olive gs-olive deleted the remove_implicit_batch_refs branch April 23, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths needs-release-cherrypick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants