Skip to content

fix: Repair integer inputs in dynamic shape cases #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Repair integer inputs in dynamic shape cases #2891

merged 1 commit into from
Jun 6, 2024

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jun 5, 2024

Description

  • Cherry-pick of fix: Repair integer inputs in dynamic shape cases #2876

  • Generative inference with HF text generation models such as gpt2 can fail if graph segmentation causes a symbolic integer to be passed from Torch to TRT, since the Torch output is an integer, while TRT expects a tensor

  • Added logic to the modules to address this case

  • Added test cases to validate generation with both Python and C++ runtimes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Repair integer inputs in dynamic shape cases
18f3627 
- Generative inference with HF text generation models such as gpt2 can
fail if graph segmentation causes a symbolic integer to be passed from
Torch to TRT, since the Torch output is an integer, while TRT expects a
tensor
- Added logic to the modules to address this case
- Added test cases to validate generation with both Python and C++
runtimes
@gs-olive gs-olive requested a review from peri044 June 5, 2024 20:55
@gs-olive gs-olive self-assigned this Jun 5, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 5, 2024
@github-actions github-actions bot requested a review from narendasan June 5, 2024 20:56
peri044
peri044 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks !!

narendasan
narendasan approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit 88ee123 into release/2.3 Jun 6, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 peri044 approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gs-olive @narendasan @peri044 @facebook-github-bot @lanluo-nvidia